Remove setState on unmounted component warning #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3470 this warning can cause unwarranted concern in users.
Following the path of React, where this warning was removed facebook/react#22114 (comment) it can likely be similarly removed from Preact.
Basically, Preact already checks if the component is unmounted, hence its ability to provide the warning, and most users that run into this implement anti-patterns to suppress the warning instead of addressing the actual issue being warned about.
The actual issue is less likely to be an indication of a real memory leak, and more likely to be just a single late update.
With all this in mind, it makes sense to also remove the warning here.
What this does:
Resolves #3470